Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useful tools and optmize image #83

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ntarocco
Copy link
Contributor

@ntarocco ntarocco commented Dec 2, 2024

Should pass when #84 is merged.

Adds a few tools to the image like ps, top, less , wget and network/file stats.

It also changes the Docker layers to improve optimization.
Removes Development tools, which looks unused. This reduces the total image size.

Before:
Total Image size: 2.0 GB

After:
Screenshot 2024-12-02 at 18 33 34

In any case, to reduce the final Docker image size, we should take advantage of multi-stage build as much as possible in the final app image (not here).


# copy everything inside /src
RUN mkdir -p ${WORKING_DIR}/src
# Invenio file will in <WORKING_DIR>/src
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Invenio file will in <WORKING_DIR>/src
# Invenio file will be in <WORKING_DIR>/src

* add a few useful debugging tools that can be used in a deployed env to
  see what is happening
* change a few Docker step to optimize the image
* remove "Development Tools" to decrease total image size
@ntarocco ntarocco force-pushed the feature/useful-tools branch from b5ba539 to fb6b814 Compare December 4, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To release 🤖
Development

Successfully merging this pull request may close these issues.

2 participants